Skip to content

Fix intermittent QA error -- Expand button not bound to JS

What does this MR do?

Clicks the Expand button again if it was clicked too quickly, seemingly before the JS was bound to the button.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Failures:

  1) GitLab Geo project rename replication user renames project
     Failure/Error: page.rename_to(geo_project_renamed)
     
     Selenium::WebDriver::Error::UnknownError:
       unknown error: Element <input type="submit" name="commit" value="Rename project" class="btn btn-warning"> is not clickable at point (330, 698). Other element would receive the click: <section class="advanced-settings no-animate settings">...</section>
         (Session info: headless chrome=63.0.3239.132)
         (Driver info: chromedriver=2.34.522932 (4140ab217e1ca1bec0c4b4d1b148f3361eb3a03e),platform=Mac OS X 10.13.2 x86_64)
     # ./qa/page/project/settings/advanced.rb:27:in `rename_project!'
     # ./qa/page/project/settings/advanced.rb:15:in `rename_to'
     # ./qa/specs/features/ee/geo/rename_replication_spec.rb:35:in `block (5 levels) in <module:QA>'
     # ./qa/scenario/actable.rb:14:in `perform'
     # ./qa/page/project/settings/main.rb:14:in `block in expand_advanced_settings'
     # ./qa/page/project/settings/common.rb:22:in `block (2 levels) in expand_section'
     # ./qa/page/project/settings/common.rb:19:in `block in expand_section'
     # ./qa/page/project/settings/common.rb:18:in `expand_section'
     # ./qa/page/project/settings/main.rb:13:in `expand_advanced_settings'
     # ./qa/specs/features/ee/geo/rename_replication_spec.rb:34:in `block (4 levels) in <module:QA>'
     # ./qa/scenario/actable.rb:14:in `perform'
     # ./qa/specs/features/ee/geo/rename_replication_spec.rb:33:in `block (3 levels) in <module:QA>'
     # ./qa/runtime/browser.rb:105:in `perform'
     # ./qa/runtime/browser.rb:27:in `visit'
     # ./qa/runtime/browser.rb:31:in `visit'
     # ./qa/specs/features/ee/geo/rename_replication_spec.rb:5:in `block (2 levels) in <module:QA>'
     # ./qa/specs/runner.rb:22:in `perform'
     # ./qa/scenario/template.rb:7:in `block in perform'
     # ./qa/scenario/template.rb:5:in `tap'
     # ./qa/scenario/template.rb:5:in `perform'
     # ./qa/ee/scenario/test/geo.rb:27:in `perform'
     # ./qa/scenario/template.rb:7:in `block in perform'
     # ./qa/scenario/template.rb:5:in `tap'
     # ./qa/scenario/template.rb:5:in `perform'
     # ./qa/scenario/bootable.rb:26:in `launch!'

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Edited by Grzegorz Bizon

Merge request reports