Skip to content

Dynamic CI secret variables

Eric Eastwood requested to merge 39118-dynamic-pipeline-variables-fe into master

What does this MR do?

CE backport: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/16842


Projects Groups

Mobile

Environment scope dropdown

Are there points in the code the reviewer needs to double check?

How to run the QA tests

Replace http://192.168.1.135:3010 with your own GDK IP/port

bin/qa Test::Instance http://192.168.1.135:3010 qa/specs/features/project/add_secret_variable_spec.rb

You can see what is going on with the CHROME_HEADLESS env option, see https://gitlab.com/gitlab-org/gitlab-qa

CHROME_HEADLESS=false bin/qa Test::Instance http://192.168.1.135:3010 qa/specs/features/project/add_secret_variable_spec.rb

Sub-MRs

Why was this MR needed?

Does this MR meet the acceptance criteria?

Todo

  • Detect change event on environments dropdown to create new row
  • Add in secret_values and reveal button
  • Wait for BE for dynamic group variables
  • Hook up ajax call data
  • Wait for BE validation messages and print in flash message
  • Double check potential e2e tests leftover from removed group/projects /variables endpoints
  • Double check potential links(path helpers _path) leftover from removed group/projects /variables endpoints
  • Add Karma tests
  • Add rspec tests
  • Update QA specs, qa/qa/factory/resource/secret_variable.rb, qa/qa/page/project/settings/secret_variables.rb, qa/qa/specs/features/project/add_secret_variable_spec.rb

What are the relevant issue numbers?

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/39118

Edited by Kamil Trzciński

Merge request reports