Add standard web hook headers to Jenkins CI post
Closes #534 (closed)
The Jenkins web hook was not sending the standard web hook headers. Specifically, the gitlab-plugin
for Jenkins needs to use the X-GitLab-Event
header. This makes our EE service unable to work with the newer GitLab Plugin for Jenkins. See https://github.com/jenkinsci/gitlab-plugin/issues/272
cc/ @rspeicher Do you have some tips on how I can write a spec for this? I stared at it for a while but am not sure how to assert only on the header piece I care about, and not the whole set of post
args. Thanks for your help.
Merge request reports
Activity
@dblessing I'd have to look at it more. Can you add an example of what you want to do but can't, even if it's a failing spec for now?
@rspeicher Added a spec that's failing but outlines what I'm looking to do. Maybe you have some idea how to test for HTTParty request headers?
@dblessing I think you'll need to stub the request with WebMock and then check to make sure it was requested with the appropriate header(s).
Edited by Robert SpeicherAdded 1039 commits:
- cb6b1098...bb3f427d - 1038 commits from branch
gitlab-org:master
- d6fc6f8f - Add standard web hook headers to Jenkins CI post
- cb6b1098...bb3f427d - 1038 commits from branch
Added 1 commit:
- 69472849 - Add standard web hook headers to Jenkins CI post
Reassigned to @rspeicher
Milestone changed to %8.8
mentioned in commit e7e4cf00
@rspeicher Thanks for the quick review and for the pointer to webmock.
mentioned in commit f6f5ff74
mentioned in issue #637 (closed)
mentioned in issue #259
mentioned in merge request !476 (merged)
mentioned in commit 23520789
mentioned in commit 647f587b
Mentioned in commit 647f587b
Mentioned in commit 23520789
added Enterprise Edition label