Disable autocomplete for epics
What does this MR do?
Disable autocomplete for epics
Are there points in the code the reviewer needs to double check?
Shouldn't be
Why was this MR needed?
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Tests added for this feature/bug -
Backport for CE - Review
-
Has been reviewed by Frontend
-
What are the relevant issue numbers?
Merge request reports
Activity
assigned to @ClemMakesApps
added 1 commit
- ca04f46b - Add rspec for checking disabled autocomplete
added ~2978933 ~127620 epics labels
changed milestone to %10.2
marked the checklist item Changelog entry added, if necessary as completed
@filipa can you review? I added a spec just for epic description editing because there is already one for issue description as seen in https://gitlab.com/gitlab-org/gitlab-ce/blob/master/spec/features/issues/form_spec.rb#L211
assigned to @filipa
@ClemMakesApps please add tests for all the changed vue components
Please assign only when pipeline is green :)
assigned to @ClemMakesApps
added 567 commits
-
7957b66b...af687aa1 - 566 commits from branch
master
- f00151d6 - Merge branch 'master' into 'disable-autocomplete'
-
7957b66b...af687aa1 - 566 commits from branch
please add tests for all the changed vue components
It's actually pretty challenging to spy on an imported module's constructor. Considering how this is a regression level bug and considering how it already has rspec integrated tests, I think this is sufficiently tested/covered.
@fatihacet can you review?
assigned to @fatihacet
assigned to @ClemMakesApps
assigned to @fatihacet
LGTM, thanks @ClemMakesApps
mentioned in commit c97b60cb
mentioned in commit 211594cc
Picked into https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/3573, will merge into
10-2-stable-ee
ready for10.2.3-ee
Edited by Tiago Botelhoadded Enterprise Edition label
added Category:Portfolio Management label