Skip to content

Resolve "Data and Privacy Agreement for GitLab users"

This was originally implemented in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/30808, but caused test failures in EE and is now correctly targeting EE with necessary CE backporting.

What does this MR do?

Add notification for an updated privacy policy.

The callout name for the privacy policy update is tagged with the issue number in case we have subsequent privacy policy updates which may warrant new notifications in the future.

This also fixes some flaky tests in ee/spec/support/shared_examples/gold_trial_callout_shared_examples.rb.

Screenshots

Merge Request View File View Project View Dashboard Project View
Screen_Shot_2019-07-16_at_23.14.56 Screen_Shot_2019-07-16_at_23.14.44 Screen_Shot_2019-07-16_at_23.14.29 Screen_Shot_2019-07-16_at_23.14.00

Testing instructions

Remove the Gitlab.com? check in app/views/layouts/_page.html.haml, start your GDK, and view any page to see the banner!

One can remove the callout dismissal record via psql.

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Closes #13665 (closed)

Edited by Dennis Tang

Merge request reports