Allow downgrade when no users were added in previous period
What does this MR do?
It compares the restricted users count against the current active users when the customer is downgrading and hasn't added more users in the previous period.
Are there points in the code the reviewer needs to double check?
Why was this MR needed?
Because customers were unable to upload their license keys due to validation errors.
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
https://gitlab.com/gitlab-com/customers-gitlab-com/issues/103
Merge request reports
Activity
assigned to @stanhu
@stanhu can you please review?
- Resolved by Rubén Dávila
- Resolved by Rubén Dávila
assigned to @rdavila
added 153 commits
-
e953a65f...5fe12452 - 152 commits from branch
master
- 7f60757f - Allow downgrade when no users were added in previous period
-
e953a65f...5fe12452 - 152 commits from branch
@stanhu thanks for reviewing, I've updated the MR, can you please review again?
assigned to @stanhu
- Resolved by Rubén Dávila
assigned to @rdavila
changed milestone to %9.0
added 148 commits
-
7f60757f...d893b691 - 147 commits from branch
master
- 3d4a8c7d - Allow downgrade when no users were added in previous period
-
7f60757f...d893b691 - 147 commits from branch
assigned to @stanhu
I've updated the MR @stanhu, thanks for reviewing!
added 148 commits
-
7f60757f...d893b691 - 147 commits from branch
master
- 3d4a8c7d - Allow downgrade when no users were added in previous period
-
7f60757f...d893b691 - 147 commits from branch
enabled an automatic merge when the pipeline for 3d4a8c7d succeeds
mentioned in commit 5f1cc738
I think would be nice to also include it in the next patch for
8.17
. /cc @jameslopezchanged milestone to %8.17
removed ~2278661b label
added Enterprise Edition label