Skip to content
Snippets Groups Projects

Allow downgrade when no users were added in previous period

Merged Rubén Dávila requested to merge skip-historical-max-check-on-downgrades into master
All threads resolved!

What does this MR do?

It compares the restricted users count against the current active users when the customer is downgrading and hasn't added more users in the previous period.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Because customers were unable to upload their license keys due to validation errors.

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

https://gitlab.com/gitlab-com/customers-gitlab-com/issues/103

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Stan Hu
  • assigned to @rdavila

  • Rubén Dávila added 153 commits

    added 153 commits

    Compare with previous version

  • Rubén Dávila resolved all discussions

    resolved all discussions

  • Author Contributor

    @stanhu thanks for reviewing, I've updated the MR, can you please review again?

  • assigned to @stanhu

  • Stan Hu
  • Stan Hu resolved all discussions

    resolved all discussions

  • assigned to @rdavila

  • Stan Hu changed milestone to %9.0

    changed milestone to %9.0

  • I assume this is a ~"Pick into Stable"?

  • Rubén Dávila added ~149424 label

    added ~149424 label

  • Rubén Dávila resolved all discussions

    resolved all discussions

  • Rubén Dávila added 148 commits

    added 148 commits

    Compare with previous version

  • assigned to @stanhu

  • Author Contributor

    I've updated the MR @stanhu, thanks for reviewing!

  • Rubén Dávila added 148 commits

    added 148 commits

    Compare with previous version

  • Stan Hu approved this merge request

    approved this merge request

  • Stan Hu enabled an automatic merge when the pipeline for 3d4a8c7d succeeds

    enabled an automatic merge when the pipeline for 3d4a8c7d succeeds

  • merged

  • Stan Hu mentioned in commit 5f1cc738

    mentioned in commit 5f1cc738

  • Author Contributor

    I think would be nice to also include it in the next patch for 8.17. /cc @jameslopez

  • Contributor

    Picked into 9-0-stable-ee and will go into 9.0.1

  • DJ Mountney changed milestone to %8.17

    changed milestone to %8.17

  • removed ~2278661b label

  • Please register or sign in to reply
    Loading