Resolve "Feature flag audit log substitute `_` to ` `"
What does this MR do?
This MR removes a character substitution that was performed on messages provided by AuditEvent instances (ie. substitution was replacing _ into a space).
However, this substitution is removed only for AuditEvent instances related to Feature Flags. Based on what I saw in the code, there can be many types linked to AuditEvent instances, and in some of these cases, the substitution may be legit and should be performed.
BEcause of this reason and to remain within the scope of what was observed in https://gitlab.com/gitlab-org/gitlab-ee/issues/10359, we're only removing the substution for events related to Feature Flags.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #10359 (closed)