Skip to content

[EE] App label warning for deploy boards

Thong Kuah requested to merge app-label-warning into master

What does this MR do?

Show warning if any deployments has label app=CI_ENVIRONMENT_SLUG. Note the warning won't show if there's an app label where the value does not match CI_ENVIRONMENT_SLUG

Dependent on https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/14020

CE Backport MR: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/29740

https://gitlab.com/gitlab-org/gitlab-ee/issues/11209

Manual QA

Scenario Screenshot -
Auto DevOps deployment Screen_Shot_2019-06-17_at_4.27.39_PM
Auto DevOps deployment + nginx with app=production label Screen_Shot_2019-06-17_at_4.27.43_PM
nginx with app=production label (fixed) Screen_Shot_2019-06-18_at_9.42.47_AM

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports