Skip to content

Encrypt feature flags client tokens

Krasimir Angelov requested to merge ee-57918-encrypt-feature-flags-tokens into master

What does this MR do?

This MR changes feature flags client token to encrypted: :optional. Unencrypted tokens will be removed in subsequent release.

There are migrations to:

  • Change existing token column to nit null so that we can stop writing to it.
  • Add new token_encrypted column
  • Add new index by project_id and token_encrypted.
  • Post deployment migration to encrypt existing tokens.

Migrations are ported from (as per https://gitlab.com/gitlab-org/gitlab-ee/issues/11252).

Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/57918.

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports