Remove nils from project_statistics.packages_size
What does this MR do?
This is a plain port of gitlab-org/gitlab-ce!28400 it only fixes a conflict in db/schema.rb
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
1 Message This merge request adds or changes files that require a review from the Database team. Database Review
The following files require a review from the Database team:
db/migrate/20190516155724_change_packages_size_defaults_in_project_statistics.rb
db/schema.rb
To make sure these changes are reviewed, take the following steps:
- Edit your merge request, and add
gl-database
to the list of Group approvers. - Mention
@gl-database
in a separate comment, and explain what needs to be reviewed by the team. Please don't mention the team until your changes are ready for review.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend Francisco Javier López ( @fjsanpedro
)James Lopez ( @jameslopez
)database Yun Guo ( @yguo
)Andreas Brandl ( @abrandl
)Generated by
DangerEdited by 🤖 GitLab Bot 🤖changed milestone to %12.0
added backend backstage [DEPRECATED] database + 1 deleted label
added 154 commits
-
aa4d65be...ecda2031 - 152 commits from branch
master
- ad8b70bf - Remove nils from project_statistics.packages_size
- 5e145086 - Test packages_size before running the migration
-
aa4d65be...ecda2031 - 152 commits from branch
@nolith FYI I've rebased this MR against master and cherry-picked the latest CE commit, in case DB decides to merge it right away
added 345 commits
-
5e145086...58c4a03a - 344 commits from branch
master
- e62c6f97 - Remove nils from project_statistics.packages_size
-
5e145086...58c4a03a - 344 commits from branch
added 193 commits
-
e62c6f97...3469e336 - 192 commits from branch
master
- d7c4a389 - Remove nils from project_statistics.packages_size
-
e62c6f97...3469e336 - 192 commits from branch
added 115 commits
-
d7c4a389...a1848c8b - 114 commits from branch
master
- f8f35ff7 - Remove nils from project_statistics.packages_size
-
d7c4a389...a1848c8b - 114 commits from branch
added 127 commits
-
f8f35ff7...c145e7f2 - 126 commits from branch
master
- 9d2753db - Remove nils from project_statistics.packages_size
-
f8f35ff7...c145e7f2 - 126 commits from branch
rebased on
master
because of master:broken failuresenabled an automatic merge when the pipeline for 9d2753db succeeds
mentioned in commit 89e3c850