Skip to content

Guard against nil file key

rossfuhrman requested to merge rf-guard-against-nil-file into master

What does this MR do?

It has been discovered that location may be present, but location['file'] can be nil. This also causes the Security Dashboard to fail to load.

Container Scanning and DAST vulnerabilities do have a location, but no file property.

This change adds a check to guard against the file property being nil.

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/11512

Merge request reports