Skip to content

Fix selection of scoped labels

Jan Provaznik requested to merge scoped-labels-ordering-fix into master

What does this MR do?

When we pick last selected label between scoped labels, we use default index 0 for any labels missing in users selection. This is a problem because if user selects only single label, then this single label has index 0 in the list of selected labels too. To avoid this, any missing labels have index set to -1.

Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/11158

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports