Add existence checks before creating the timelogs table and time_estimate columns

Closes #1578 (closed).

assigned to @rymai

@rymai Thanks for creating this MR! I left just a single question.

added 1 commit

• 1215fb6d - Add existence checks before creating the timelogs table and time_estimate columns

Compare with previous version

@grzesiek Thanks, I've made the migrations reversible! I will backport these changes to CE as well.

added 1 commit

• 39fdae28 - Add existence checks before creating the timelogs table and time_estimate columns

Compare with previous version

assigned to @rspeicher

resolved all discussions

enabled an automatic merge when the pipeline for 39fdae28 succeeds

mentioned in commit 6fb89ee2

merged

@rymai This should be a patch, I think?

added ~149424 label

@dblessing I believe that this problem does not exist in stable branches. Customers should be able to upgrade without difficulties, only upgrade from latest version of GitLab to EE on master branch didn't work before merging this fix. I'm going to remove ~"Pick into Stable" label, feel free to add it again if you have feedback from customers which conflicts with what am I saying here

removed ~149424 label

@grzesiek Support has seen this with several customers trying to upgrade from CE to EE.

@dblessing Interesting! Then indeed this might be an important fix which should be included in path release. Let's add the label again and ping @rymai about confirmation.

added ~149424 label

If I understand correctly, the reason this needs picked is because it would cause a migration error if a person upgraded to 8.16 CE and then tried to migrate to 8.16 EE - the earlier of the two migrations (the one fixed in this MR) would run second and blow up. That's why we need both to have the unless table_exists?. It's a bit confusing, so I'm typing this as much for my own sanity as anyone else's.

@dblessing I think your explanation makes sense. Better be safe than sorry, let's include this in the next patch! /cc @jameslopez

changed milestone to %8.16

Picked into 8-16-stable-ee, will be in 8.16.3

removed ~149424 label

mentioned in commit bb670aa6

mentioned in issue #9391 (closed)

added Enterprise Edition label