Skip to content

Fix scoped_label? check for admin view

Jan Provaznik requested to merge scoped-labels-fix into master

What does this MR do?

Fixes rendering of scoped labels on admin labels page. On admin page labels are instances of Label, so subject method is not available there.

Note that there will be further improvement of the feature check - https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/10862, but because this is a bigger refactoring it is done separately.

Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/11141

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Coung Ngo

Merge request reports