Copy LFS objects when a repository is pull mirrored
What does this MR do?
Copies LFS objects into the repository when it is pull mirrored.
Does this MR meet the acceptance criteria?
Conformity
Merge request reports
Activity
changed milestone to %11.11
added Create [DEPRECATED] Deliverable GitLab Starter backend customer devopscreate direction mirroring repository typefeature workflowin dev + 1 deleted label
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend João Cunha ( @Alexand)Sean McGivern ( @smcgivern)frontend Andrew Fontaine ( @afontaine)Kushal Pandya ( @kushalpandya)Generated by
Edited by 🤖 GitLab Bot 🤖marked the checklist item Changelog entry as completed
added 1 commit
- fb9f0ceb - Making the pull operation fail when Lfs import fails
@reprazent can you take a look at this MR? I'm going on holidays next week and I want to speed things up in the meanwhile.
Most of this MR is part of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/27255 (you're already assigned to that one as well). Once it gets merged, I will rebase this one.
Basically, the only modified files in this MR are:
ee/spec/services/projects/update_mirror_service_spec.rbee/app/services/projects/update_mirror_service.rb- the view files
assigned to @reprazent
-
@fjsanpedro Only minor things here, let's get the other MR in first
assigned to @fjsanpedro
added 300 commits
-
d6ef98b6...fd3fdd2a - 299 commits from branch
master - bddc322e - Importing LFS objects in pull mirror
-
d6ef98b6...fd3fdd2a - 299 commits from branch
added 1430 commits
-
acaafa08...9d6b6fbf - 1429 commits from branch
master - 639b93f8 - Importing LFS objects in pull mirror
-
acaafa08...9d6b6fbf - 1429 commits from branch
-
@reprazent the MR is rebased with the last changes in master. Can you take another look?
assigned to @reprazent
assigned to @fjsanpedro
-
Sorry @reprazent I had to fix a small thing with the view. I will have to create a CE port to fix the change but it's a small one, so we can review this and, once it's ready, create the port.
assigned to @reprazent
marked the checklist item Code review guidelines as completed
marked the checklist item Merge request performance guidelines as completed
marked the checklist item Style guides as completed
marked the checklist item Database guides as completed
marked the checklist item Separation of EE specific content as completed
-
@fjsanpedro Thanks to the small refactor, this is quite straightforward, thanks!
assigned to @fjsanpedro
-
Thanks @reprazent! Changes applied.
assigned to @reprazent
- Resolved by Sean McGivern
Thanks @fjsanpedro The 2 failures seem unrelated.
Could you create the backport? Then I think it's ready for a maintainer!
- Last reply by Sean McGivern
assigned to @fjsanpedro
-
@smcgivern do you mind to take a look?
assigned to @smcgivern
-
ee-specific-lines-check is just failing because the branch names don't match. LGTM, thanks @fjsanpedro!
mentioned in commit ba0cf469
-
Thanks @smcgivern!. About
ee-specific-lines-checkafter I realized of the names, I expected not to failed once the port was merge because I think the check fallback to master. mentioned in issue gitlab-org/release/tasks#778 (closed)
added Enterprise Edition label
added Category:Source Code Management label and removed 1 deleted label