Skip to content

Refactor Service Desk's bot user

Peter Leitzen requested to merge pl-user-bot_type into master

What does this MR do?

This MR makes adding user bot accounts easier by introducing the enum User.bot_type (with support_bot as only value for now) and stop using users.support_bot boolean database column. We also replace specific support_bot? checks with the more generic bot? where it makes sense.

After this MR we will be able to add more bot accounts (such as GitLab Alert Bot) more easily. See https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/10460

No need to

  • add a boolean database column e.g. alert_bot
  • extend existing support_bot? checks with || alert_bot? in several places

Just

  • extend the enum bot_type by e.g. alert_bot
  • add new alert_bot? if needed

CE backport https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/26671

What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab-ee/issues/10159

Does this MR meet the acceptance criteria?

Edited by 🤖 GitLab Bot 🤖

Merge request reports