Approval rule not finalized with approvers after merge
Summary
Sometimes, when approval rule is set on merge request level (MR override is enabled), after MR is merged, the approval widget wrongly displays that some more approvals are still required.
Since this does not impact on the approval process or the merge process, but merely displaying the incorrect information, I've labeled it as S2.
Steps to reproduce
- Enable MR approval override
- Create merge request with approval rules
- Approves MR as another user.
- Merge MR
Example Project
What is the current bug behavior?
Records are not created under approval_merge_request_rules_approved_approvers
.
After page refresh, approval widget displays "Requires x more approvals from foo and bar.".
What is the expected correct behavior?
Records are created under approval_merge_request_rules_approved_approvers
.
After page refresh, approval widget displays "Approved".
Relevant logs and/or screenshots
Output of checks
(If you are reporting a bug on GitLab.com, write: This bug happens on GitLab.com)
Results of GitLab environment info
Results of GitLab application Check
Possible fixes
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/9648
Remove safety check for now.