Better Specs recommendations
I'd like to get some discussion around potentially folding in some of the recommendations from http://www.betterspecs.org into our https://docs.gitlab.com/ee/development/testing_guide/best_practices.html
In particular I like the 'Single expectation test' (http://www.betterspecs.org/#single) and wish for us to add to our Testing best practices document:
The 'one expectation' tip is more broadly expressed as 'each test should make only one assertion'. This helps you on finding possible errors, going directly to the failing test, and to make your code readable.
In isolated unit specs, you want each example to specify one (and only one) behavior. Multiple expectations in the same example are a signal that you may be specifying multiple behaviors.
Anyway, in tests that are not isolated (e.g. ones that integrate with a DB, an external webservice, or end-to-end-tests), you take a massive performance hit to do the same setup over and over again, just to set a different expectation in each test. In these sorts of slower tests, I think it's fine to specify more than one isolated behavior.
There's lots of great content on betterspecs.org so there may be other recommendations worth examining & discussing.