Approvals are not reset after a new push is made if the request is coming from a fork
- Zendesk ticket: https://gitlab.zendesk.com/agent/tickets/11787
- GitLab version: 8.1.4-ee
Description of issue
If you require approvals for your merge request to be accepted, but are submitting merge requests from forks, the approvals list does not get reset if a new push is made to the fork.
Result of replication
I was able to replicate this behavior.
- Create fork & edit
- Create merge request
- Approve merge request
- Push something new to fork
- Approval is not reset
I double checked and the setting to reset approvals is active.
Concrete questions / Next steps
@vsizov I believe the approvals feature was not implemented to handle new pushes from forks. Is that the case?