Test plan for "Send one email notification for one published code review"
Introduction
This test plan is for https://gitlab.com/gitlab-org/gitlab-ee/issues/4326. It extends https://gitlab.com/gitlab-org/gitlab-ee/issues/7275. The feature sends a single email notification for a Review (as opposed to one email per comment as is currently the case).
Scope
- EE-only
- Unless we can implement a suitable method of automatically verifying the content of emails, that part will have to be tested manually.
ACC Matrix
| Secure | Responsive | Intuitive | Reliable | |
|---|---|---|---|---|
| MRs | ||||
For more information see the Google Testing Blog article about the 10 minute test plan and this wiki page from an open-source tool that implements the ACC model.
Capabilities
Email is
- Reliable
- All comments in the Review are included in the email, including non-code comments.
- Comments that are not in the Review are not included in the email.
- All links navigate to the appropriate GitLab content.
Test Plan
Scenario 1: Email with included and excluded comments
(ideally this would be automated)
- Add code and non-code comments to an MR that aren't part of a review.
- Start a review and add code and non-code comments. Have one resolve a discussion and another unresolve a discussion.
- Submit the review and check that all review comments are included and that all non-review comments are not included.
- Check that resolution status changes are reported.
- Check that a code comment in the email navigates to the correct comment in the MR.
- Repeat for a non-code comment.
Edited by 🤖 GitLab Bot 🤖