Reviews: Resolving or unresolving discussions with “Add comment now” does not work
Follow-up to discussion in https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/7376#note_106554094.
Discussion is resolved, checkbox reads “Unresolve discussion”:
Checkbox selected | Checkbox not selected | |
---|---|---|
Expected behavior | All comments (incl. new one) should be unresolved when submitting/publishing. Pending comment reads “Discussion will be unresolved”. | All comments (incl. new one) should stay resolved when submitting/publishing. Pending comment reads “Discussion stays resolved”. |
Add now-route |
|
OK |
Review-route | OK | OK |
Discussion is unresolved, checkbox reads “Resolve discussion”:
Checkbox selected | Checkbox not selected | |
---|---|---|
Expected behavior | All comments (incl. new one) should be resolved when submitting/publishing. Pending comment reads “Discussion will be resolved”. | All comments (incl. new one) should stay unresolved when submitting/publishing. Pending comment reads “Discussion stays unresolved”. |
Add now-route |
|
OK |
Review-route | OK | OK |
Edited by Pedro Moreira da Silva