Improve error message when uploading a license with a trueup

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

• Close this issue

Problem to solve

We show an error to renewing instances that 1) have a true-up in their previous period, and 2) attempt to upload a license with an insufficient trueup count or user count.

It reads "During the year before this license started, this GitLab installation had X users, exceeding this license's limit of Y by Y-X. Please upload a license for at least X or contact sales at renewals@gitlab.com".

Users find this language confusing.

Further details

The relevant code is in license.rb:

  def add_limit_error(current_period: true, user_count:)
    overage = user_count - restricted_user_count

    message =  current_period ? "This GitLab installation currently has " : "During the year before this license started, this GitLab installation had "
    message << "#{number_with_delimiter(user_count)} active #{"user".pluralize(user_count)}, "
    message << "exceeding this license's limit of #{number_with_delimiter(restricted_user_count)} by "
    message << "#{number_with_delimiter(overage)} #{"user".pluralize(overage)}. "
    message << "Please upload a license for at least "
    message << "#{number_with_delimiter(user_count)} #{"user".pluralize(user_count)} or contact sales at renewals@gitlab.com"

    self.errors.add(:base, message)
  end

(Include use cases, benefits, and/or goals)

Proposal

TBD

Links / references