Comments are lost when replying to removed lines
One of my guys reported the following to me:
Comments are lost when replying to outdated diffs on lines that are (being) removed in new commits.
Steps to Reproduce:
- Push some changes
- Create a comment to some line
- Push a change that removes most of the lines -- number of lines in that file must be less than a line number of the line commented in step 2.
- Create a reply on outdated diff discussion (created in step 2).
Actual results: Step 4 will create a new discussion block with no comments/replies.
Expected results: Reply is added to correct discussion section.
These comments are lost and not displayed by the UI. They only appear in emails. If the behaviour described in issue #717 (closed) is intentional, then the comments/replies should be displayed there. It seems that the line number of original reply does not exists in new state (after pushing new changes), thus the comments/replies are not rendered (?).