Extract EE specific files/lines for spec/features/security/group
We have the following files containing EE specific code. We should move them to ee/
spec/features/security/group/internal_access_spec.rb
diff --git a/spec/features/security/group/internal_access_spec.rb b/home/yorickpeterse/Projects/gitlab/gdk-ee/gitlab/spec/features/security/group/internal_access_spec.rb
index 51b32ba6c03..2e4eb7ff94c 100644
--- a/spec/features/security/group/internal_access_spec.rb
+++ b/home/yorickpeterse/Projects/gitlab/gdk-ee/gitlab/spec/features/security/group/internal_access_spec.rb
@@ -22,6 +22,7 @@ describe 'Internal Group access' do
subject { group_path(group) }
it { is_expected.to be_allowed_for(:admin) }
+ it { is_expected.to be_allowed_for(:auditor) }
it { is_expected.to be_allowed_for(:owner).of(group) }
it { is_expected.to be_allowed_for(:maintainer).of(group) }
it { is_expected.to be_allowed_for(:developer).of(group) }
@@ -37,6 +38,7 @@ describe 'Internal Group access' do
subject { issues_group_path(group) }
it { is_expected.to be_allowed_for(:admin) }
+ it { is_expected.to be_allowed_for(:auditor) }
it { is_expected.to be_allowed_for(:owner).of(group) }
it { is_expected.to be_allowed_for(:maintainer).of(group) }
it { is_expected.to be_allowed_for(:developer).of(group) }
@@ -53,6 +55,7 @@ describe 'Internal Group access' do
subject { merge_requests_group_path(group) }
it { is_expected.to be_allowed_for(:admin) }
+ it { is_expected.to be_allowed_for(:auditor) }
it { is_expected.to be_allowed_for(:owner).of(group) }
it { is_expected.to be_allowed_for(:maintainer).of(group) }
it { is_expected.to be_allowed_for(:developer).of(group) }
@@ -68,6 +71,7 @@ describe 'Internal Group access' do
subject { group_group_members_path(group) }
it { is_expected.to be_allowed_for(:admin) }
+ it { is_expected.to be_allowed_for(:auditor) }
it { is_expected.to be_allowed_for(:owner).of(group) }
it { is_expected.to be_allowed_for(:maintainer).of(group) }
it { is_expected.to be_allowed_for(:developer).of(group) }
@@ -83,6 +87,7 @@ describe 'Internal Group access' do
subject { edit_group_path(group) }
it { is_expected.to be_allowed_for(:admin) }
+ it { is_expected.to be_denied_for(:auditor) }
it { is_expected.to be_allowed_for(:owner).of(group) }
it { is_expected.to be_denied_for(:maintainer).of(group) }
it { is_expected.to be_denied_for(:developer).of(group) }
spec/features/security/group/private_access_spec.rb
diff --git a/spec/features/security/group/private_access_spec.rb b/home/yorickpeterse/Projects/gitlab/gdk-ee/gitlab/spec/features/security/group/private_access_spec.rb
index 4705cd12d23..c51132ae939 100644
--- a/spec/features/security/group/private_access_spec.rb
+++ b/home/yorickpeterse/Projects/gitlab/gdk-ee/gitlab/spec/features/security/group/private_access_spec.rb
@@ -22,6 +22,7 @@ describe 'Private Group access' do
subject { group_path(group) }
it { is_expected.to be_allowed_for(:admin) }
+ it { is_expected.to be_allowed_for(:auditor) }
it { is_expected.to be_allowed_for(:owner).of(group) }
it { is_expected.to be_allowed_for(:maintainer).of(group) }
it { is_expected.to be_allowed_for(:developer).of(group) }
@@ -37,6 +38,7 @@ describe 'Private Group access' do
subject { issues_group_path(group) }
it { is_expected.to be_allowed_for(:admin) }
+ it { is_expected.to be_allowed_for(:auditor) }
it { is_expected.to be_allowed_for(:owner).of(group) }
it { is_expected.to be_allowed_for(:maintainer).of(group) }
it { is_expected.to be_allowed_for(:developer).of(group) }
@@ -53,6 +55,7 @@ describe 'Private Group access' do
subject { merge_requests_group_path(group) }
it { is_expected.to be_allowed_for(:admin) }
+ it { is_expected.to be_allowed_for(:auditor) }
it { is_expected.to be_allowed_for(:owner).of(group) }
it { is_expected.to be_allowed_for(:maintainer).of(group) }
it { is_expected.to be_allowed_for(:developer).of(group) }
@@ -68,6 +71,7 @@ describe 'Private Group access' do
subject { group_group_members_path(group) }
it { is_expected.to be_allowed_for(:admin) }
+ it { is_expected.to be_allowed_for(:auditor) }
it { is_expected.to be_allowed_for(:owner).of(group) }
it { is_expected.to be_allowed_for(:maintainer).of(group) }
it { is_expected.to be_allowed_for(:developer).of(group) }
@@ -83,6 +87,7 @@ describe 'Private Group access' do
subject { edit_group_path(group) }
it { is_expected.to be_allowed_for(:admin) }
+ it { is_expected.to be_denied_for(:auditor) }
it { is_expected.to be_allowed_for(:owner).of(group) }
it { is_expected.to be_denied_for(:maintainer).of(group) }
it { is_expected.to be_denied_for(:developer).of(group) }
spec/features/security/group/public_access_spec.rb
diff --git a/spec/features/security/group/public_access_spec.rb b/home/yorickpeterse/Projects/gitlab/gdk-ee/gitlab/spec/features/security/group/public_access_spec.rb
index 3a53c3c2bc7..ab9e5b63ca8 100644
--- a/spec/features/security/group/public_access_spec.rb
+++ b/home/yorickpeterse/Projects/gitlab/gdk-ee/gitlab/spec/features/security/group/public_access_spec.rb
@@ -22,6 +22,7 @@ describe 'Public Group access' do
subject { group_path(group) }
it { is_expected.to be_allowed_for(:admin) }
+ it { is_expected.to be_allowed_for(:auditor) }
it { is_expected.to be_allowed_for(:owner).of(group) }
it { is_expected.to be_allowed_for(:maintainer).of(group) }
it { is_expected.to be_allowed_for(:developer).of(group) }
@@ -37,6 +38,7 @@ describe 'Public Group access' do
subject { issues_group_path(group) }
it { is_expected.to be_allowed_for(:admin) }
+ it { is_expected.to be_allowed_for(:auditor) }
it { is_expected.to be_allowed_for(:owner).of(group) }
it { is_expected.to be_allowed_for(:maintainer).of(group) }
it { is_expected.to be_allowed_for(:developer).of(group) }
@@ -53,6 +55,7 @@ describe 'Public Group access' do
subject { merge_requests_group_path(group) }
it { is_expected.to be_allowed_for(:admin) }
+ it { is_expected.to be_allowed_for(:auditor) }
it { is_expected.to be_allowed_for(:owner).of(group) }
it { is_expected.to be_allowed_for(:maintainer).of(group) }
it { is_expected.to be_allowed_for(:developer).of(group) }
@@ -68,6 +71,7 @@ describe 'Public Group access' do
subject { group_group_members_path(group) }
it { is_expected.to be_allowed_for(:admin) }
+ it { is_expected.to be_allowed_for(:auditor) }
it { is_expected.to be_allowed_for(:owner).of(group) }
it { is_expected.to be_allowed_for(:maintainer).of(group) }
it { is_expected.to be_allowed_for(:developer).of(group) }
@@ -83,6 +87,7 @@ describe 'Public Group access' do
subject { edit_group_path(group) }
it { is_expected.to be_allowed_for(:admin) }
+ it { is_expected.to be_denied_for(:auditor) }
it { is_expected.to be_allowed_for(:owner).of(group) }
it { is_expected.to be_denied_for(:maintainer).of(group) }
it { is_expected.to be_denied_for(:developer).of(group) }
Edited by Yorick Peterse