Improve role/user/group selection for protected branches/tags
Selecting roles/users/groups that can merge/push a protected branch or create a protected tag is combined in one dropdown:
This has a few flaws as mentioned in https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/5091
- For displaying numbers, dropdown items are counted which leads to
Masters + Developers
being displayed as1 role
(while it clearly should be2 roles
) - It is possible to select users/groups even if
No one
is selected. Also selectingNo one
doesn't clear selected users/groups. - Given that
No one
is an item in the dropdown, selecting no item cannot displayNo one
. - It is possible to select
Masters
andDevelopers + Masters
.
A straight-forward solution to this would probably be to split this into three dropdowns:
Edited by Inactive Account