Reconsider Deploy Boards match criteria
Right now, Deploy Boards uses the app
label to match against CI_ENVIRONMENT_SLUG
to determine which pods belong to what environment.
I think we should consider an alternate method, like:
- Matching the start of
pod name
toCI_ENVIRONMENT_SLUG
. - Matching the start of
release
label toCI_ENIVRONMENT_SLUG
.
The reasons why:
- The
app
label is not commonly configured, from what I can tell, in helm charts. It's typically set to the chart name. - The release name is quite frequently configured, and is as easy as
helm install --name $CI_ENVIRONMENT_SLUG
. - The pod names typically will start with the release name, but the benefit here is that this is what the Kubernetes auto-monitoring uses, as it is one of the few labels that is passed down to Docker. (And thus available to cAdvisor)
What I would propose is matching on either app
or release
, this way we can support additional deployments and it is likelier to "just work". And with the app
matching, we are backwards compatible.