Push event webhooks fail with InvalidURIError
Since the update to GitLab 10.5.6-ee our push event webhooks stopped working with the following error message:
Started GET "/PROJECT/hooks/NUMBER/test?trigger=push_events" for IP at TIMESTAMP
Processing by Projects::HooksController#test as HTML
Parameters: {"trigger"=>"push_events", "namespace_id"=>"GROUP", "project_id"=>"PROJECT_NAME", "id"=>"NUMBER"}
Completed 500 Internal Server Error in 46ms (ActiveRecord: 5.3ms | Elasticsearch: 0.0ms)
URI::InvalidURIError (URI::InvalidURIError):
lib/gitlab/proxy_http_connection_adapter.rb:14:in `connection'
app/services/web_hook_service.rb:73:in `make_request'
app/services/web_hook_service.rb:26:in `execute'
app/models/hooks/web_hook.rb:10:in `execute'
app/services/test_hooks/base_service.rb:22:in `block in execute'
app/services/test_hooks/base_service.rb:19:in `catch'
app/services/test_hooks/base_service.rb:19:in `execute'
app/controllers/projects/hooks_controller.rb:41:in `test'
lib/gitlab/i18n.rb:47:in `with_locale'
lib/gitlab/i18n.rb:53:in `with_user_locale'
app/controllers/application_controller.rb:333:in `set_locale'
lib/gitlab/middleware/multipart.rb:95:in `call'
lib/gitlab/request_profiler/middleware.rb:14:in `call'
lib/gitlab/middleware/go.rb:17:in `call'
lib/gitlab/etag_caching/middleware.rb:11:in `call'
lib/gitlab/middleware/read_only.rb:31:in `call'
lib/gitlab/request_context.rb:18:in `call'
lib/gitlab/metrics/requests_rack_middleware.rb:27:in `call'
Here is an example webhook target URL: https://HOST/project/Some%20Project%20-%20Build (Secret Token: yes, SSL verification: yes)
A simple request to httpbin is working.
System information:
GitLab 10.5.6-ee
GitLab Shell 6.0.3
GitLab Workhorse v3.6.0
GitLab API v4
Ruby 2.3.6p384
Rails 4.2.10
postgresql