Microsoft Teams integration shows incorrect message for 'approved' Merge Request event
Summary
Incorrect message is sent to MS Teams channel when approve Merge Request: "Merge Request opened by..."
Steps to reproduce
- Add MS Teams integration to your project, filter triggers to Merge Requests only
- Create Merge Request and Approve it
What is the current bug behavior?
In chat window you will have 2 identical messages: one for opened MR and another one - for approved.
Merge Request opened by author
What is the expected correct behavior?
Message should be like:
Merge Request approved by
Results of GitLab environment info
Expand for output related to GitLab environment info
System information System: Ubuntu 16.04 Proxy: no Current User: git Using RVM: no Ruby Version: 2.3.6p384 Gem Version: 2.6.13 Bundler Version:1.13.7 Rake Version: 12.3.0 Redis Version: 3.2.11 Git Version: 2.14.3 Sidekiq Version:5.0.5 Go Version: unknown
GitLab information Version: 10.5.4-ee Revision: 18e79be Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: postgresql DB Version: 9.6.5 Elasticsearch: no Geo: no Using LDAP: no Using Omniauth: no
GitLab Shell Version: 6.0.3 Repository storage paths:
- default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git