Existing approval should remain even approver is no longer eligible
Continuation of https://gitlab.com/gitlab-org/gitlab-ee/issues/4134:
Description
- Suppose that you have approved a merge request.
- Suppose that per the system logic in https://gitlab.com/gitlab-org/gitlab-ee/issues/4134, you are no longer allowed to approve because of a change.
- Everybody who navigates to the merge request will see that you have approved.
- Your approval still counts as an approval for that merge request. It is still a valid approval. It still counts. The Web UI still shows it. The API still returns it.
- When you navigate to the merge request, you can remove your approval.
- If you remove your approval, you can no longer approve it again, because you are no longer allowed to approve.
Possible reasons why you are no longer a valid approver.
- You were previously an explicit individual approver at the project level or mr level. And you were subsequently removed.
- You were previously part of a group approver at the project level or mr level.
- You were removed from that group.
- The group was removed from the project or mr as an approver.
- You were previously an implicit individual approver at the project level
- Because either
m
orn
changed in #4134 (closed), so that implicit individual approvers are no longer allowed to approve. - Your role was changed to be below Developer role.
- Because either
Edited by Victor Wu