Skip to content

Add configurable option for different email domains

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

Description

We are having an issue where emails from Gitlab have mis-matched sender names and sender addresses. We are currently using CE but have purchased EE licenses for a migration in the near future, and in evaluating this issue we see the code in question does not function differently or as needed in the EE version.

The code in question will only assign the sender's email address to the outgoing message if the domain of the sender's address matches the Gitlab server's host domain. While this is a common infrastructure configuration, it is not a universal one. Our users' email domain differs from our Gitlab server's domain, so we always see 'Susan' having our IT department group email address, for example.

Proposal

As this 'sender' function relies on a computed list of allowed email domains, we propose to make this list of allowed email domains a configurable value, and that configuration be optional. If that configuration list is not specified, the existing behavior could be retained.

Links / references

Documentation blurb

Overview

This feature would allow Gitlab to send email notifications with the correct sender name and address when the customer infrastructure uses different domains for email and the Gitlab host. When this configuration is desired, a list of email domains could be specified in the main configuration file.

Use cases

One typical use case is when a user (let's say 'Susan') comments on a Merge Request discussion. Our Gitlab server will send an email with the From: header having a display name of the sender 'Susan' but will have an email address that is the default email_from value in the Gitlab configuration.

Feature checklist

Make sure these are completed before closing the issue, with a link to the relevant commit.

Edited by 🤖 GitLab Bot 🤖