`master` seems to be broken
Two specs seems to consistently fail on the CI:
1) RegistrationsController#create when the user opted-out does not set the rest of the email_opted_in fields
Failure/Error: iwhere(username: username).take!
ActiveRecord::RecordNotFound:
Couldn't find User with [WHERE (`username` = 'user3966')]
# ./app/models/user.rb:376:in `find_by_username!'
# ./spec/ee/spec/controllers/ee/registrations_controller_spec.rb:23:in `block (4 levels) in <top (required)>'
# ./spec/spec_helper.rb:116:in `block (2 levels) in <top (required)>'
Finished in 67 minutes 57 seconds (files took 50.74 seconds to load)
1141 examples, 1 failure
Failed examples:
rspec ./spec/ee/spec/controllers/ee/registrations_controller_spec.rb:21 # RegistrationsController#create when the user opted-out does not set the rest of the email_opted_in fields– https://gitlab.com/gitlab-org/gitlab-ee/-/jobs/28997357
and
1) Signup on EE for Gitlab.com when the user does not check the opt-in to email updates box creates the user and sets the email_opted_in field falsey
Failure/Error: expect(user.email_opted_in_at).to be_nil
expected: nil
got: 2017-08-11 07:59:19.000000000 +0000
# ./spec/ee/spec/features/signup_spec.rb:46:in `block (4 levels) in <top (required)>'
# ./spec/spec_helper.rb:116:in `block (2 levels) in <top (required)>'
2) Signup on EE not for Gitlab.com does not have a opt-in checkbox, it creates the user and sets email_opted_in to falsey
Failure/Error: expect(user.email_opted_in_at).to be_nil
expected: nil
got: 2017-08-11 07:59:19.000000000 +0000
# ./spec/ee/spec/features/signup_spec.rb:72:in `block (3 levels) in <top (required)>'
# ./spec/spec_helper.rb:116:in `block (2 levels) in <top (required)>'
Finished in 23 minutes 5 seconds (files took 38.44 seconds to load)
202 examples, 2 failures
Failed examples:
rspec ./spec/ee/spec/features/signup_spec.rb:32 # Signup on EE for Gitlab.com when the user does not check the opt-in to email updates box creates the user and sets the email_opted_in field falsey
rspec ./spec/ee/spec/features/signup_spec.rb:56 # Signup on EE not for Gitlab.com does not have a opt-in checkbox, it creates the user and sets email_opted_in to falsey