Geo: GeoBulkNotifyWorker firing too frequently
I'm noticing that GeoBulkNotifyWorker
is firing quite often:
17:57:46 rails-background-jobs.1 | 2017-02-18T17:57:46.953Z 900 TID-gq09xxa94 GeoBulkNotifyWorker JID-1e097cd581fb9958db3b4eef INFO: start
17:57:46 rails-background-jobs.1 | 2017-02-18T17:57:46.953Z 900 TID-gq09xxa94 GeoBulkNotifyWorker JID-1e097cd581fb9958db3b4eef INFO: arguments: []
17:57:46 rails-background-jobs.1 | 2017-02-18T17:57:46.955Z 900 TID-gq09xxa94 GeoBulkNotifyWorker JID-1e097cd581fb9958db3b4eef INFO: done: 0.001 sec
17:57:46 rails-background-jobs.1 | 2017-02-18T17:57:46.956Z 900 TID-gq09xx878 INFO: Cron Jobs - add job with name: geo_bulk_notify_worker
17:58:00 rails-background-jobs.1 | 2017-02-18T17:58:00.906Z 900 TID-gq09xymw8 GeoBulkNotifyWorker JID-3cd0f3848b396ad44edb82a6 INFO: start
17:58:00 rails-background-jobs.1 | 2017-02-18T17:58:00.906Z 900 TID-gq09xymw8 GeoBulkNotifyWorker JID-3cd0f3848b396ad44edb82a6 INFO: arguments: []
17:58:00 rails-background-jobs.1 | 2017-02-18T17:58:00.908Z 900 TID-gq09xymw8 GeoBulkNotifyWorker JID-3cd0f3848b396ad44edb82a6 INFO: done: 0.002 sec
17:58:00 rails-background-jobs.1 | 2017-02-18T17:58:00.910Z 900 TID-gq09xx878 INFO: Cron Jobs - add job with name: geo_bulk_notify_worker
17:58:11 rails-background-jobs.1 | 2017-02-18T17:58:11.202Z 900 TID-gq09xxajo GeoBulkNotifyWorker JID-ff9fe8c61f74c4b54a8af56a INFO: start
17:58:11 rails-background-jobs.1 | 2017-02-18T17:58:11.202Z 900 TID-gq09xxajo GeoBulkNotifyWorker JID-ff9fe8c61f74c4b54a8af56a INFO: arguments: []
17:58:11 rails-background-jobs.1 | 2017-02-18T17:58:11.203Z 900 TID-gq09xxajo GeoBulkNotifyWorker JID-ff9fe8c61f74c4b54a8af56a INFO: done: 0.001 sec
17:58:11 rails-background-jobs.1 | 2017-02-18T17:58:11.206Z 900 TID-gq09xx878 INFO: Cron Jobs - add job with name: geo_bulk_notify_worker
17:58:24 rails-background-jobs.1 | 2017-02-18T17:58:24.059Z 900 TID-gq09xyo3k GeoBulkNotifyWorker JID-0f6397789e4d4d166b5505cb INFO: start
17:58:24 rails-background-jobs.1 | 2017-02-18T17:58:24.059Z 900 TID-gq09xyo3k GeoBulkNotifyWorker JID-0f6397789e4d4d166b5505cb INFO: arguments: []
17:58:24 rails-background-jobs.1 | 2017-02-18T17:58:24.060Z 900 TID-gq09xyo3k GeoBulkNotifyWorker JID-0f6397789e4d4d166b5505cb INFO: done: 0.002 sec
17:58:24 rails-background-jobs.1 | 2017-02-18T17:58:24.062Z 900 TID-gq09xx878 INFO: Cron Jobs - add job with name: geo_bulk_notify_worker
17:58:46 rails-background-jobs.1 | 2017-02-18T17:58:46.295Z 900 TID-gq09xynu4 GeoBulkNotifyWorker JID-2e5b0a989ef58fc8a47c6122 INFO: start
17:58:46 rails-background-jobs.1 | 2017-02-18T17:58:46.295Z 900 TID-gq09xynu4 GeoBulkNotifyWorker JID-2e5b0a989ef58fc8a47c6122 INFO: arguments: []
17:58:46 rails-background-jobs.1 | 2017-02-18T17:58:46.297Z 900 TID-gq09xynu4 GeoBulkNotifyWorker JID-2e5b0a989ef58fc8a47c6122 INFO: done: 0.002 sec
17:58:46 rails-background-jobs.1 | 2017-02-18T17:58:46.299Z 900 TID-gq09xx878 INFO: Cron Jobs - add job with name: geo_bulk_notify_worker
I see a number of problems:
-
Every Sidekiq worker runs this cron job. We should limit to 1 worker, perhaps with an
ExclusiveLease
. -
The crontab entry is actually invalid: https://crontab.guru/#/10_*__*