Merge Request Comments Disappear Randomly
Summary
Comments on merge request are disappearing seemingly at random.
Steps to reproduce
- Unsure of the exact steps. In my case a colleague posted a Merge Request with changes in 2 files, amounting to hundreds of lines changed.
- I made around 25-30 comments on those files against many different lines.
- Colleague made changes to the files and committed/pushed again. In total there are 8 commits visible in the MR but most of them are WIP commits from before the MR was created.
- Looking at the Changes section is where the bug is displayed.
What is the current bug behavior?
Some (about 5-10%) of comments from the original round of review no longer display in the Changes section. These same comments do display in the Discussion section, though the lines they refer to do not update with the changes made with subsequent pushes. These comments are 'unresolved' so it becomes very difficult to compare the comment against the newest version of the file to determine if the issues has been satisfactorily resolved. I have to find the original line referenced and hunt it down in the Changes section, trying to remember what the issue was so I can see if it has been fixed. I've resorted to having the discussion tab open in one browser tab and the Changes tab open in another.
What is the expected correct behavior?
Merge Request comments should remain visible in the Changes tab as long as the MR can be accessed, regardless of how many commits are made. I understand that it would be unreasonable to always keep them in the correct place because of code churn, but at the very least they should remain visible in the same general area that they were originally raised. This would be much better than removing them all together.
Relevant logs and/or screenshots
Output of checks
This bug happens on GitLab.com