static-analysis fails on master
The static-analysis
job is failing on master (https://gitlab.com/gitlab-org/gitlab-ee/-/jobs/282166349) with the following:
ee/spec/controllers/groups/cycle_analytics/events_controller_spec.rb:39:9: C: RSpec/BeSuccessMatcher: Do not use deprecated success? method, use successful? instead.
expect(response).to be_success
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ee/spec/controllers/groups/cycle_analytics/events_controller_spec.rb:58:9: C: RSpec/BeSuccessMatcher: Do not use deprecated success? method, use successful? instead.
expect(response).to be_success
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ee/spec/controllers/groups/cycle_analytics_controller_spec.rb:39:9: C: RSpec/BeSuccessMatcher: Do not use deprecated success? method, use successful? instead.
expect(response).to be_success
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ee/spec/controllers/groups/cycle_analytics_controller_spec.rb:59:9: C: RSpec/BeSuccessMatcher: Do not use deprecated success? method, use successful? instead.
expect(response).to be_success
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ee/spec/controllers/projects/merge_requests_controller_spec.rb:27:7: C: RSpec/BeSuccessMatcher: Do not use deprecated success? method, use successful? instead.
expect(response).to be_success
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ee/spec/controllers/projects/merge_requests_controller_spec.rb:56:7: C: RSpec/BeSuccessMatcher: Do not use deprecated success? method, use successful? instead.
expect(response).to be_success
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ee/spec/controllers/projects/merge_requests_controller_spec.rb:83:7: C: RSpec/BeSuccessMatcher: Do not use deprecated success? method, use successful? instead.
expect(response).to be_success
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^