Add system notes for report approval rule merge request events
Problem to solve
There is no clear UI within merge requests to give a user feedback on why report approval rules are changing state. We should add system notes to provide feedback to better notify the user of state changes.
Intended users
Further details
Proposal
With the release of #9928 (closed) approval rules' approvals required can now change when they are rule_type: report_approver, but the user may not fully process why things have changed. To make this more clear system notes could be a good solution.
Generate system notes for 2 events:
- resetting approvals required
- decrementing "safe" merge request approvals to zero.
Permissions and Security
No change to permissions
Documentation
No change to docs
Testing
- When code changes, system notes should be generated
- when pipeline runs w/ no vulneraiblities, system notes should be generated
What does success look like, and how can we measure that?
System notes get generated