Comments in the Designs tab should support Todo's + Email Notifications

Problem to solve

When commenting on designs in the Design Management tab other users who may be tagged or participating in the issue are not notified nor is a Todo created.

Intended users

All users participating in issues with Designs need to functionality to support notifications and Todos.

Proposal

When a comment is left on a Design users who are participating in the discussion should receive an email notification and have a Todo created. This will ensure that discussions are actionable.

What does success look like, and how can we measure that?

Users will be notified of comments and have Todo's created. We'll be adding Usage Ping for comments to measure usage.

What is the type of buyer?

GitLab Premium

Links / references

changed milestone to %12.2

added Category:Design Management Deliverable GitLab Premium backend devopscreate typefeature + 1 deleted label

marked this issue as related to #11851 (closed)

changed the description

added [deprecated] Accepting merge requests label

changed weight to 2

added Product Vision FY20 label

assigned to @alexkalderimis

removed [deprecated] Accepting merge requests label

added workflowin dev label

Do we have comments working on designs on any branch at the moment @phikai ?

I'm not sure what the state of @ntepluhina's branch is, but you can see the MR here: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/14648

Discussions and comments are there

Great, thanks for the info

created merge request !14804 (merged) to address this issue

mentioned in merge request !14804 (merged)

This is definitely working on @ntepluhina's branch.

If I create a note on a design, eg.:

and I then query the database, I see that there is indeed a pending To-Do for Jake:

[9] pry(main)> Todo.where(user: jake)
  Todo Load (0.3ms)  SELECT "todos".* FROM "todos" WHERE "todos"."user_id" = $1  [["user_id", 5]]
=> [#<Todo:0x00005564c96fb228
  id: 90,
  user_id: 5,
  project_id: 1,
  target_id: 11,
  target_type: "DesignManagement::Design",
  author_id: 1,
  action: 2,
  state: "pending",
  created_at: Tue, 23 Jul 2019 21:17:50 UTC +00:00,
  updated_at: Tue, 23 Jul 2019 21:17:50 UTC +00:00,
  note_id: 945,
  commit_id: nil,
  group_id: nil>,
 #<Todo:0x00005564c96fb0e8
  id: 26,
  user_id: 5,
  project_id: 4,
  target_id: 32,
  target_type: "Issue",
  author_id: 5,
  action: 1,
  state: "done",
  created_at: Mon, 22 Jul 2019 21:46:10 UTC +00:00,
  updated_at: Mon, 22 Jul 2019 21:46:10 UTC +00:00,
  note_id: nil,
  commit_id: nil,
  group_id: nil>]

This verifies the tests in !14804 (merged) , which suggests that this issue is in fact already working.

closed via merge request !14804 (merged)

mentioned in commit 9196c6c4

@alexkalderimis Is the corresponding email also sent?

It behaves exactly as the notes behaviour elsewhere. I am happy to test that too, but it seems like overkill, since this follows precisely the same codepath as if you had created a comment on an issue.

Thanks for confirming @alexkalderimis. That sounds good to me.

mentioned in issue gl-retrospectives/create-stage/knowledge#2 (closed)

added Enterprise Edition label

mentioned in issue #13494 (closed)

mentioned in merge request !15250 (merged)

reopened

Milestone %12.2 for this Deliverable issue has expired and the issue is considered a missed-deliverable.

added missed-deliverable label

added to epic &660 (closed)

changed milestone to %12.3

added missed:12.2 label

mentioned in issue #13792 (closed)

added workflowin review label and removed workflowin dev label

mentioned in issue gitlab-com/www-gitlab-com#5218 (closed)

mentioned in merge request gitlab-com/www-gitlab-com!29952 (merged)

closed via merge request !15250 (merged)

mentioned in commit 27f7c92d

mentioned in issue gitlab-com/www-gitlab-com#9140 (closed)

added devopsplan groupproduct planning labels and removed devopscreate + 1 deleted label