Multiple assignees merge request system notes bug
Summary
Reassigning merge request assignees with the multiple assignees feature active doesn't yield correct system notes.
Steps to reproduce
- Open a merge request with an assignee
- Assign yourself as assignee without unassigning the other one (using a quick command)
- Unassign the original assignee using a quick command
- Now you only see a systemnote detailing that the original assignee has been removed. We are missing the notice of the new assignee being assigned.
Note: I might have used a subdiscussion to trigger the quick command which only included the quick command as its contents.
Example Project
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/27920
What is the current bug behavior?
There is no system note detailing the new assignee
What is the expected correct behavior?
System note should detail both the unassignment and assignment of the assignees.
Relevant logs and/or screenshots
Output of checks
This bug happens on GitLab.com
Results of GitLab environment info
Expand for output related to GitLab environment info
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:env:info
)(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production
)
Results of GitLab application Check
Expand for output related to the GitLab application check
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true
)(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true
)(we will only investigate if the tests are passing)
Possible fixes
(If you can, link to the line of code that might be responsible for the problem)