SAML providers frontend fixture fails
On a fresh master
clone the following frontend fixture fails when running bin/rake karma:fixtures
:
1) Groups::SamlProvidersController (JavaScript fixtures) groups/saml_providers/show.html
Failure/Error:
super.tap do
# Set a header for custom error pages to prevent them from being intercepted by gitlab-workhorse
if response.content_type == 'text/html' && (400..599).cover?(response.status)
response.headers['X-GitLab-Custom-Error'] = '1'
end
ActionView::Template::Error:
undefined method `user_group_saml_omniauth_authorize_path' for #<ActionDispatch::Routing::RoutesProxy:0x00007fea75751568>
# ./ee/app/helpers/ee/saml_providers_helper.rb:23:in `saml_link'
# ./ee/app/helpers/ee/saml_providers_helper.rb:18:in `saml_link_for_provider'
# ./ee/app/views/groups/saml_providers/_test_button.html.haml:1:in `_ee_app_views_groups_saml_providers__test_button_html_haml___2170914373066631542_70322484599300'
# ./ee/app/views/groups/saml_providers/_form.html.haml:67:in `block in _ee_app_views_groups_saml_providers__form_html_haml__4184429372439088192_70322265673780'
# ./ee/app/views/groups/saml_providers/_form.html.haml:2:in `_ee_app_views_groups_saml_providers__form_html_haml__4184429372439088192_70322265673780'
# ./ee/app/views/groups/saml_providers/show.html.haml:13:in `_ee_app_views_groups_saml_providers_show_html_haml__867019686079511878_70322493069980'
# ./app/controllers/application_controller.rb:117:in `render'
# ./lib/gitlab/session.rb:11:in `with_session'
# ./app/controllers/application_controller.rb:439:in `set_session_storage'
# ./lib/gitlab/i18n.rb:55:in `with_locale'
# ./lib/gitlab/i18n.rb:61:in `with_user_locale'
# ./app/controllers/application_controller.rb:435:in `set_locale'
# ./ee/spec/javascripts/fixtures/saml_providers.rb:26:in `block (2 levels) in <main>'
# ./spec/support/helpers/javascript_fixtures_helpers.rb:13:in `block (3 levels) in <module:JavaScriptFixturesHelpers>'
# ./spec/support/helpers/javascript_fixtures_helpers.rb:13:in `block (2 levels) in <module:JavaScriptFixturesHelpers>'
# ------------------
# --- Caused by: ---
# NoMethodError:
# undefined method `user_group_saml_omniauth_authorize_path' for #<ActionDispatch::Routing::RoutesProxy:0x00007fea75751568>
# ./ee/app/helpers/ee/saml_providers_helper.rb:23:in `saml_link'
Finished in 34.43 seconds (files took 8.5 seconds to load)
26 examples, 1 failure
Failed examples:
rspec ./ee/spec/javascripts/fixtures/saml_providers.rb:23 # Groups::SamlProvidersController (JavaScript fixtures) groups/saml_providers/show.html
Inserting
- { name: 'group_saml' }
inside the test > omniauth > providers
of config/gitlab.yml
fixes it but we should make it right away.