LDAP group sync broken
Summary
After upgrading to 8.13.0, some group membership assignments were removed from groups that sync members from LDAP.
When viewing group's Manage Access page, "Sync now" button is not clickable and the text on the button is "Syncing".
Reverting back to 8.12.7 fixed the issue.
Steps to reproduce
Expected behavior
- Group sync working like in version 8.12
- Being able to manually sync group members from manage group access page
Actual behavior
Relevant logs and/or screenshots
Nothing out of ordinary in sidekiq.log:
2016-10-25T06:00:01.982Z 16624 TID-gs5oq79sc LdapGroupSyncWorker JID-68f8146b208a37d9031671ca INFO: Finished LDAP group sync
2016-10-25T06:00:01.982Z 16624 TID-gs5oq79sc LdapGroupSyncWorker JID-68f8146b208a37d9031671ca INFO: done: 0.023 sec```
But production.log looks a bit weird (from around 2016-10-25 09:00:01 +0300):
```Performing daily LDAP sync task.
Group 'PHP' is not ready for LDAP sync. Skipping
Group '.NET' is not ready for LDAP sync. Skipping
Group 'Centralised' is not ready for LDAP sync. Skipping
Scoped order and limit are ignored, it's forced to be batch order and batch size
LDAP search error: No Such Object```
### Output of checks
#### Results of GitLab application Check
I cannot provide these now as I had to revert to 8.12 ASAP as several people didn't have write access to projects. I can upgrade to 8.13 again tomorrow morning to get output for these if needed.
(For installations with omnibus-gitlab package run and paste the output of:
`sudo gitlab-rake gitlab:check SANITIZE=true`)
(For installations from source run and paste the output of:
`sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true`)
(we will only investigate if the tests are passing)
#### Results of GitLab environment info
(For installations with omnibus-gitlab package run and paste the output of:
`sudo gitlab-rake gitlab:env:info`)
(For installations from source run and paste the output of:
`sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)
### Possible fixes
-