Move approval user password input from inline to a modal
#5981 (closed) adds a “Require user password to approve” option which shows an inline password input when the user attempts to approve a merge request:
Instead of doing this inline, consider using a modal. A modal not only blocks the workflow and focuses on the confirmation, but also to moves the password input to another “layer”. With the the password input in the middle of the merge request page, it's on a “layer” shared by multiple users. With the modal approach, inputting one's password can seem more private.
Enter your password to approve
To approve this merge request, please enter your password. This project requires all approvals to be authenticated.
- Password field (auto-focused on modal open) label:
Cancel(default, gray button)
Approve(primary, blue button)