Allow to select a specific Insights chart page using an anchor.
That would be nice to select a different Insights page than the first one by using a URL anchor (e.g. #issuesDashboard
).
- Allow the address to identify the page to load
- Update the URL when the insights page changes to reference the page's unique key
- Allow the address to identify the chart on the page to focus on
- Allow this address to be copied
- Possibly add a link which contains this reference close to each chart
Designs
- Show closed items
Relates to
- gitlab-foss #66203
- #31021Awaiting further demand
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Rémy Coutable added Quality insights typefeature labels
added Quality insights typefeature labels
- Author Maintainer
This should be an EE issue!
🤦 - Author Maintainer
I think this shouldn't be difficult to do it in the frontend:
- Fetch the anchor:
- I there is one and the chart config has a corresponding key, issue a query to get the page's data
- else, issue a query to get the first page's data
- Rémy Coutable added frontend label
added frontend label
- Rémy Coutable changed weight to 2
changed weight to 2
- Rémy Coutable added to epic &725 (closed)
added to epic &725 (closed)
- Mek Stittri changed milestone to %12.0
changed milestone to %12.0
- Contributor
The challenge is when we delete charts from the
yaml
file. Do we expect a redirect for existing anchors? I don't think we should save redirects, it would complicate things and it is a nice to have.I would suggest just falling back to the parent url which is the first dropdown or ask user to pick a chart in the dropdown.
Collapse replies - Author Maintainer
Do we expect a redirect for existing anchors? I don't think we should save redirects, it would complicate things and it is a nice to have.
No, if the chart tab cannot be found, just fetch the default tab, this is basically the "else, issue a query to get the first page's data" clause I stated above.
- 🤖 GitLab Bot 🤖 added [deprecated] Accepting merge requests label
added [deprecated] Accepting merge requests label
- Rémy Coutable changed epic to &1196
changed epic to &1196
- Mek Stittri changed milestone to %12.1
changed milestone to %12.1
- Contributor
I think we need this to make insights more useful for sub-departments and groups. Moved to %12.1 let me know if we need more time.
- Mek Stittri assigned to @markglenfletcher
assigned to @markglenfletcher
- 🤖 GitLab Bot 🤖 removed [deprecated] Accepting merge requests label
removed [deprecated] Accepting merge requests label
- Contributor
We spoke about the information to be made available in the URL to allow selection of a page and possibly a chart upon loading:
- Allow the address to identify the page to load
- Update the URL when the insights page changes to reference the page's unique key
- Allow the address to identify the chart on the page to focus on
- Allow this address to be copied
- Possibly add a link which contains this reference close to each chart
- 🤖 GitLab Bot 🤖 mentioned in issue #13044 (closed)
mentioned in issue #13044 (closed)
- 🤖 GitLab Bot 🤖 changed milestone to %12.2
changed milestone to %12.2
- 🤖 GitLab Bot 🤖 added missed:12.1 label
added missed:12.1 label
- 🤖 GitLab Bot 🤖 added Enterprise Edition label
added Enterprise Edition label
- Mek Stittri changed milestone to %12.3
changed milestone to %12.3
- Contributor
Moved to %12.3 we also have an internal customer usecase from the CEO shadow program https://gitlab.com/gitlab-org/gitlab-ce/issues/66203
- Rémy Coutable added internal customer label
added internal customer label
- Rémy Coutable changed the description
changed the description
- Contributor
Is it essential to be able to select the specific chart on the page? Would it suffice to be able to use an anchor to target a specific tab/dashboard.
For example, with the default insights tabs. The
mergeRequests
anchor can be used to navigate directly to the second (non-default) dashboard tab. - Mark Fletcher mentioned in merge request !16904 (merged)
mentioned in merge request !16904 (merged)
- 🤖 GitLab Bot 🤖 mentioned in issue #32506 (closed)
mentioned in issue #32506 (closed)
- 🤖 GitLab Bot 🤖 added missed:12.3 label
added missed:12.3 label
- 🤖 GitLab Bot 🤖 mentioned in issue #32729 (closed)
mentioned in issue #32729 (closed)
- 🤖 GitLab Bot 🤖 changed milestone to %12.4
changed milestone to %12.4
- Kyle Wiebers added Engineering Productivity label
added Engineering Productivity label
- Rémy Coutable closed via merge request !16904 (merged)
closed via merge request !16904 (merged)
- Rémy Coutable mentioned in commit f560fedd
mentioned in commit f560fedd