Restructure project merge request settings page

changed milestone to %11.11

added Category:Continuous Delivery Category:Continuous Integration GitLab Premium PM Ready Product Vision 2018 customer direction documentation frontend internal customer + 1 deleted label

mentioned in issue #7380 (closed)

/remind @nfriend to take a look at what's currently in place and update @dimitrieh

(I wish /remind was actually a thing.)

created merge request !10491 (merged) to address this issue

mentioned in merge request !10491 (merged)

changed the description

@dimitrieh I'm going to move this back to %11.10 since this lines up with the milestone associated with https://gitlab.com/gitlab-org/gitlab-ee/issues/7380#project-settings-merge-request-settings.

changed milestone to %11.10

@axil Do you know if any docs will need to be updated after this change is made? I took a look through all the pages I thought might be related to this feature, but I didn't see anything obvious that will need to be updated.

@nfriend from a quick search, I only found this section that would need to be updated https://docs.gitlab.com/ee/user/project/merge_requests/merge_when_pipeline_succeeds.html#only-allow-merge-requests-to-be-merged-if-the-pipeline-succeeds.

Also, can you clarify what you mean by

Added option for enabling merge request pipelines for merged result

Is this the option about validating the post-merge pipeline? If so, we should document this somewhere.

@axil That's a good question. I copied this mockup from the original issue. @dimitrieh, do you know what this comment means in your original mockup?

Added option for enabling merge request pipelines for merged result

I don't see any options in the mockup that don't already exist in the current settings page.

Also, good catch on the documentation page, @axil. I'll update that screenshot and the appropriate text as part of this MR.

Actually, I'll open a separate MR for this change to avoid holding up the current one.

@nfriend @axil this point refers to the following option which has been added

Great, thanks for clarifying!

added Deliverable label

mentioned in issue #10882 (closed)

removed direction label

mentioned in issue #9186 (closed)

marked this issue as related to #9186 (closed)

@jlenny Just FYI, this issue didn't make it through review before the code freeze, so it missed %11.10. This is a minor rearranging of the project merge requests settings described in https://gitlab.com/gitlab-org/gitlab-ee/issues/7380#project-settings-merge-request-settings and won't affect the release of the main feature.

/cc @jhampton