Only subset of group may actually end up in approvers list for project
When choosing a group to review a MR, a subset of members may be listed as approvers to the MR when it is created. This has been seen by several users within the organisation who have ventured into using groups.
To me this doesn't appear related to #2164 as that only mentions TODOs rather than the approvers list.
Steps to reproduce
Exact circumstances not known: create a PR where the default list of approvers is a single group, leave that group selected when creating.
This project (private, so presumably only available to GitLab engineers) doesn't have a CODEOWNERS file to complicate things:
https://gitlab.com/mintel/satoshi/infrastructure/ansible-satoshi/merge_requests/162 (original - was merged; was missing
https://gitlab.com/mintel/satoshi/infrastructure/ansible-satoshi/merge_requests/164 (test - won't be changed; missing all team members except
@aharrison-fuller- project requires 2 approvers)
When I tried to reproduce it with https://gitlab.com/mintel/satoshi/infrastructure/ansible-satoshi/merge_requests/165 through to https://gitlab.com/mintel/satoshi/infrastructure/ansible-satoshi/merge_requests/168 the issue was not reproduced, I was hoping to see if the subset was constant depending on the user creating the MR, or some other pattern. The difference in during these tests was that the list of default/suggested approvers explicitly included each member of the group (as a workaround for groups seeming borked), but I removed the individual users so just the group was left.
What is the current bug behavior?
A seemingly random subset of the group may be added to the list of approvers.
What is the expected correct behavior?
All members of the group are added to the list of approvers
Relevant logs and/or screenshots
<imagine the frowning faces of users as they encountered it here>
Output of checks
N/A (silver gitlab.com subscription)
I'm not convinced this is the issue described in #2164 as that only mentions TODOs rather than the list of valid approvers. Not using groups isn't exactly a solution.