Skip to content

Set GO111MODULE=off when installing workhorse and pages

Adrien Kohlbecker requested to merge ak/fix-go-modules into master

I happened to have a go.mod file in upper directories above my gdk install, which was making go use modules. This resulted in the following error:

GOPATH=/Users/ak/Work/gitlab/gdk-ce/gitlab-pages GOBIN=/Users/ak/Work/gitlab/gdk-ce/gitlab-pages/bin go install gitlab.com/gitlab-org/gitlab-pages
# gitlab.com/gitlab-org/gitlab-pages/internal/admin
gitlab-pages/pkg/mod/gitlab.com/gitlab-org/gitlab-pages@v1.6.1/internal/admin/auth.go:10:36: not enough arguments in call to gitalyauth.CheckToken
    have ("context".Context, string)
    want ("context".Context, string, time.Time)

Indeed, gitlab-pages has a vendored gitaly that is lagging behind upstream. Running go install with modules enabled would ignore the vendored directory and pick the code from master.

Setting GO111MODULE=off makes the expected behaviour explicit.

Merge request reports