Makefile is missing `shell`?
While hacking on the Makefile
(!425 (closed)) I noticed this line:
gitlab_from_container = $(shell [ "$(uname)" = "Linux" ] && echo 'localhost' || echo 'docker.for.mac.localhost')
Isn't there a shell
missing in $(uname)
, so it should read $(shell uname)
?
gitlab_from_container = $(shell [ "$(shell uname)" = "Linux" ] && echo 'localhost' || echo 'docker.for.mac.localhost')
Maybe on Linux this is different (and therefore the logic still works), but at least on my MacOS it does only work with shell
.