Refactor PostgreSQL logic
What does this Merge Request do and why?
This MR aims to refactor and improve the PostgreSQL logic to make upcoming relating MRs less complex.
Merge Request checklist
-
This change is backward compatible. If not, please include steps to communicate to our users. -
Tests added for new functionality. If not, please raise Issue to follow-up. -
Documentation added/updated, if needed. -
gdk doctor
test added, if needed. -
Add the ~highlight
label if this MR should be included in theCHANGELOG.md
.
Merge request reports
Activity
added Category:GDK Engineering Productivity Quality labels
assigned to @ashmckenzie
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Reviewer Maintainer No reviewer available Toon Claes ( @toon
) (UTC+2, 8 hours behind@ashmckenzie
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerchanged milestone to %15.2
added typemaintenance label
mentioned in merge request !2574 (closed)
@toon as mentioned over at !2574 (diffs, comment 1026043500), may you please review this, thanks.
requested review from @toon
- Resolved by Ash McKenzie
- Resolved by Ash McKenzie
- Resolved by Ash McKenzie
@ashmckenzie No serious comments, feel free to ignore my comments, pre-approving.
removed review request for @toon
changed milestone to %15.3
- Resolved by Ash McKenzie
mentioned in merge request gitlab!103657 (merged)
changed milestone to %15.6
changed milestone to %15.11
changed milestone to %16.0
added 832 commits
-
c64bfa3a...51368702 - 826 commits from branch
main
- ef401d9a - Add some spacing for readability
- 597bb2ac - Inject GDK.config and use config objects more
- 1b117d12 - Rename to #stub_pg_version_file
- 863912c4 - Pull #stub_pg_data_dir from #stub_pg_version_file
- c11e930f - Add coverage for #current_data_dir and #psql_cmd
- 2cc709b4 - Add coverage for #ready?
Toggle commit list-
c64bfa3a...51368702 - 826 commits from branch
1 Warning Please add a merge request subtype to this merge request. Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer None Lukas Eipert (
@leipert
) (UTC+2, 8 hours behind@ashmckenzie
)Tiger Watson (
@tigerwnz
) (UTC+10, same timezone as@ashmckenzie
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded maintenancerefactor label
added 54 commits
-
2cc709b4...ef858e51 - 48 commits from branch
main
- f3e80c83 - Add some spacing for readability
- 2b600a11 - Inject GDK.config and use config objects more
- 494a2d96 - Rename to #stub_pg_version_file
- 6cdbe1c3 - Pull #stub_pg_data_dir from #stub_pg_version_file
- 9d6f9727 - Add coverage for #current_data_dir and #psql_cmd
- 51f066fc - Add coverage for #ready?
Toggle commit list-
2cc709b4...ef858e51 - 48 commits from branch
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer None Lukas Eipert (
@leipert
) (UTC+2, 8 hours behind@ashmckenzie
)Tiger Watson (
@tigerwnz
) (UTC+10, same timezone as@ashmckenzie
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerTested and @toon has already approved, so merging
mentioned in commit 8f59b9aa