Skip to content
Snippets Groups Projects

Refactor PostgreSQL logic

Merged Ash McKenzie requested to merge ashmckezie/refactor-postgresql-logic-1 into main
All threads resolved!

What does this Merge Request do and why?

This MR aims to refactor and improve the PostgreSQL logic to make upcoming relating MRs less complex.

Merge Request checklist

  • This change is backward compatible. If not, please include steps to communicate to our users.
  • Tests added for new functionality. If not, please raise Issue to follow-up.
  • Documentation added/updated, if needed.
  • gdk doctor test added, if needed.
  • Add the ~highlight label if this MR should be included in the CHANGELOG.md.
Edited by Ash McKenzie

Merge request reports

Merge train pipeline #858015813 passed

Merge train pipeline passed for 6ea9493e

Approved by

Merged by Ash McKenzieAsh McKenzie 1 year ago (May 5, 2023 6:36am UTC)

Merge details

  • Changes merged into main with 8f59b9aa.
  • Deleted the source branch.
  • Auto-merge enabled

Pipeline #858018776 failed

Pipeline failed for 8f59b9aa on main

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Toon Claes resolved all threads

    resolved all threads

  • Toon Claes
  • Toon Claes approved this merge request

    approved this merge request

  • Toon Claes removed review request for @toon

    removed review request for @toon

  • Ash McKenzie changed milestone to %15.3

    changed milestone to %15.3

  • Anatoli Babenia
  • Ash McKenzie mentioned in merge request gitlab!103657 (merged)

    mentioned in merge request gitlab!103657 (merged)

  • Ash McKenzie changed milestone to %15.6

    changed milestone to %15.6

  • Ash McKenzie changed milestone to %15.11

    changed milestone to %15.11

  • Ash McKenzie changed milestone to %16.0

    changed milestone to %16.0

  • Ash McKenzie added 832 commits

    added 832 commits

    • c64bfa3a...51368702 - 826 commits from branch main
    • ef401d9a - Add some spacing for readability
    • 597bb2ac - Inject GDK.config and use config objects more
    • 1b117d12 - Rename to #stub_pg_version_file
    • 863912c4 - Pull #stub_pg_data_dir from #stub_pg_version_file
    • c11e930f - Add coverage for #current_data_dir and #psql_cmd
    • 2cc709b4 - Add coverage for #ready?

    Compare with previous version

  • 1 Warning
    :warning: Please add a merge request subtype to this merge request.

    Reviewer roulette

    Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.

    Category Reviewer Maintainer
    None Lukas Eipert current availability (@leipert) (UTC+2, 8 hours behind @ashmckenzie) Tiger Watson current availability (@tigerwnz) (UTC+10, same timezone as @ashmckenzie)

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Ash McKenzie added 54 commits

    added 54 commits

    • 2cc709b4...ef858e51 - 48 commits from branch main
    • f3e80c83 - Add some spacing for readability
    • 2b600a11 - Inject GDK.config and use config objects more
    • 494a2d96 - Rename to #stub_pg_version_file
    • 6cdbe1c3 - Pull #stub_pg_data_dir from #stub_pg_version_file
    • 9d6f9727 - Add coverage for #current_data_dir and #psql_cmd
    • 51f066fc - Add coverage for #ready?

    Compare with previous version

  • Reviewer roulette

    Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.

    Category Reviewer Maintainer
    None Lukas Eipert current availability (@leipert) (UTC+2, 8 hours behind @ashmckenzie) Tiger Watson current availability (@tigerwnz) (UTC+10, same timezone as @ashmckenzie)

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Author Maintainer

    Performing a final test locally of this branch :pray:

  • Author Maintainer

    Tested and @toon has already approved, so merging :thumbsup:

  • Ash McKenzie resolved all threads

    resolved all threads

  • Ash McKenzie started a merge train

    started a merge train

  • merged

  • Ash McKenzie mentioned in commit 8f59b9aa

    mentioned in commit 8f59b9aa

  • Please register or sign in to reply
    Loading