Discrepancy between workhorse -listenAddr and nginx server

This was already raised in !841 (merged):

I'm not sure we need this for nginx too, but I'll allow it for now.

When this is merged I might revisit this in !787 (merged).

Problem

When nginx is enabled, the Procfile will contain:

gitlab-workhorse: exec /usr/bin/env PATH="..." gitlab-workhorse ... -listenAddr 0.0.0.0:3333 ...

But in nginx/conf/nginx.conf you might get something like:

  upstream gitlab-workhorse {
    server geo.test:3333 fail_timeout=0;
  }

If you're only running 1 GDK, this will not be a problem, because workhorse will just listen on any address. But if you want multiple GDKs in parallel (i.e. when running Geo) this will cause workhorse failing to start and both nginx instances will route traffic to the same workhorse. I got an error like this:

Blocked host: geo.test To allow requests to geo.test, add the following to your environment configuration:

config.hosts << "geo.test"