GDK reconfigure doesn't reflect PostgreSQL port change
When making any modification on PostgreSQL port gdk reconfigure
doesn't reflect that change on postgres configuration.
Part of the reason to that is that postgresql/port
target in Makefile is not called as part of the reconfigure.
Another issue is that postgresql/data/postgres.conf
file has the port initially commented as : # port 5432
, and the script file that changes the port, has a regexp that ignores that initial comment bit. Ideally it should "uncomment" as well as change the number.
There is no side-effect in uncommenting that. Even when using it with unix sockets, the port is part of the socket name, so that should always be modified.
Here is an example of what error we should see when modifying the port (which changes it in rails, but not in postgres.conf):
gdk reconfigure
warning Resolution field "ts-jest@24.0.0" is incompatible with requested version "ts-jest@^23.10.5"
Updated 0 paths from the index
-------------------------------------------------------
Installing jaeger 1.10.1..
-------------------------------------------------------
(in /Users/brodock/Projetos/Gitlab/gdk-ee)
ok: run: ./services/postgresql: (pid 45987) 117s, normally down
ok: run: ./services/praefect: (pid 45984) 117s, normally down
ok: run: ./services/praefect-gitaly-0: (pid 45985) 117s, normally down
ok: run: ./services/redis: (pid 45986) 117s, normally down
ok: run: ./services/gitaly: (pid 47105) 0s, normally down
psql: could not connect to server: No such file or directory
Is the server running locally and accepting
connections on Unix domain socket "/Users/brodock/Projetos/Gitlab/gdk-ee/postgresql/.s.PGSQL.5433"?
Cannot connect to postgres
after this two issues are fixed, we shouldn't see this anymore.