`make Procfile` aborts with "NoMethodError: undefined method `storage'"
While updating my gdk using gdk update
, when doing a make Procfile
, I get NoMethodError: undefined method 'storage'
. This seems to be due to this change
Adding a binding.pry
at https://gitlab.com/gitlab-org/gitlab-development-kit/blob/master/Rakefile#L94, node
is
From: /Users/walkerbl/dev/gitlab/ee/Rakefile @ line 96 :
91: GDK::ErbRenderer.new(t.source, t.name, config: config).render!
92: end
93:
94: config.praefect.nodes.each do |node|
95: binding.pry
=> 96: desc "Generate gitaly config for #{node.storage}"
97: file node.config_file => ['support/templates/gitaly.config.toml.erb'] do |t|
98: GDK::ErbRenderer.new(
99: t.source,
100: t.name,
101: config: config,
[1] pry(main)> node
=> {"address"=>#<Pathname:/Users/walkerbl/dev/gitlab/ee/gitaly-praefect-0.socket>,
"config_file"=>"gitaly/gitaly-0.praefect.toml",
"log_dir"=>#<Pathname:/Users/walkerbl/dev/gitlab/ee/log/praefect-gitaly-0>,
"primary"=>true,
"storage"=>"praefect-internal-0",
"storage_dir"=>"/Users/walkerbl/dev/gitlab/ee/repositories/praefect-internal-0"}
We need to use node['storage']
instead of node.storage