Make gdk doctor warnings not count as errors

Overview

The following discussion from !4867 (merged) should be addressed:

• @kkloss started a discussion:

  thought (non-blocking): This is really something that we should use for the doctor command. Right now, we exit regularly with code 1 if there are warnings (actionable items by the user!).

  Instead, we should always raise a UserInteractionRequired (perhaps one where no message means print! is a no-op?), so we only track unexpected Ruby errors in telemetry. That way, our success rate data for gdk doctor wouldn’t be heavily skewed:

  

Impacted categories

The following categories relate to this issue:

• gdk-reliability - e.g. When a GDK action fails to complete.
• gdk-usability - e.g. Improvements or suggestions around how the GDK functions.
• gdk-performance - e.g. When a GDK action is slow or times out.

Steps to replicate (optional)

Proposal (optional)

Environment (optional)

• Operating system name: <!-- output of `uname -a` command -->
• Architecture: <!-- output of `arch` or `uname -m` command -->
• The contents of your gdk.yml (if any)
• Ruby version: <!-- output of `ruby --version` command -->
• GDK version: <!-- output of `git rev-parse --short HEAD` command -->